Skip to content

update: clean up notation CLI#404

Merged
shizhMSFT merged 11 commits intonotaryproject:mainfrom
patrickzheng200:cleanup-main
Oct 19, 2022
Merged

update: clean up notation CLI#404
shizhMSFT merged 11 commits intonotaryproject:mainfrom
patrickzheng200:cleanup-main

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

  1. Deprecated cache/push/pull commands
  2. Removed usage of cache in all commands

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

@patrickzheng200 patrickzheng200 changed the title update: Clean up notation CLI update: clean up notation CLI Oct 18, 2022
@JeyJeyGao
Copy link
Copy Markdown
Contributor

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #404 (2cce54b) into main (20b9fa2) will increase coverage by 2.32%.
The diff coverage is 3.70%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   32.28%   34.60%   +2.32%     
==========================================
  Files          26       23       -3     
  Lines        1623     1254     -369     
==========================================
- Hits          524      434      -90     
+ Misses       1086      809     -277     
+ Partials       13       11       -2     
Impacted Files Coverage Δ
cmd/notation/common.go 100.00% <ø> (ø)
cmd/notation/main.go 0.00% <ø> (ø)
cmd/notation/sign.go 36.93% <3.70%> (-5.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 01015b0 into notaryproject:main Oct 19, 2022
@patrickzheng200 patrickzheng200 deleted the cleanup-main branch October 19, 2022 02:57
@patrickzheng200 patrickzheng200 linked an issue Oct 19, 2022 that may be closed by this pull request
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
1. Deprecated cache/push/pull commands
2. Removed usage of cache in all commands

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
1. Deprecated cache/push/pull commands
2. Removed usage of cache in all commands

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove signature cache for all(sign, verify, etc) command.

6 participants