feat: add signatureFormat config field#400
Merged
shizhMSFT merged 5 commits intonotaryproject:mainfrom Oct 31, 2022
Merged
Conversation
patrickzheng200
suggested changes
Oct 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 32.03% 32.78% +0.74%
==========================================
Files 26 26
Lines 1670 1632 -38
==========================================
Hits 535 535
+ Misses 1122 1084 -38
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
force-pushed
the
junjiegao/dev-rc.1
branch
from
a79df05 to
f0d4aff
Compare
JeyJeyGao
changed the title
rgnote
approved these changes
Oct 31, 2022
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
junjiegao/dev-rc.1
branch
2 times, most recently
from
6afdd27 to
25ec953
Compare
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
junjiegao/dev-rc.1
branch
from
25ec953 to
12c0afa
Compare
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
1. Add signatureFormat field providing the default value for --signature-format flag in config.json. 2. move GetEnvelopeMediaType() from internal/cmd/signer.go to internal/envelope/envelope.go Test: 1. signatureFormat = jws, OK 3. signatureFormat = cose, OK 4. signatureFormat = jws, --signature-format=cose, OK 5. signatureFormat = cose, --signature-format=jws, OK 6. signatureFormat = cose2, cause an `Error: signature format cose2 not supported` 7. signatureFormat = cose2, --signature-format=jws, OK Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
1. Add signatureFormat field providing the default value for --signature-format flag in config.json. 2. move GetEnvelopeMediaType() from internal/cmd/signer.go to internal/envelope/envelope.go Test: 1. signatureFormat = jws, OK 3. signatureFormat = cose, OK 4. signatureFormat = jws, --signature-format=cose, OK 5. signatureFormat = cose, --signature-format=jws, OK 6. signatureFormat = cose2, cause an `Error: signature format cose2 not supported` 7. signatureFormat = cose2, --signature-format=jws, OK Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test:
Error: signature format cose2 not supportedSigned-off-by: Junjie Gao junjiegao@microsoft.com