Skip to content

spec: add spec for notation version command#376

Merged
shizhMSFT merged 14 commits intonotaryproject:mainfrom
yizha1:spec-verify
Oct 18, 2022
Merged

spec: add spec for notation version command#376
shizhMSFT merged 14 commits intonotaryproject:mainfrom
yizha1:spec-verify

Conversation

@yizha1
Copy link
Copy Markdown
Contributor

@yizha1 yizha1 commented Oct 11, 2022

Add spec for notation version command.

@yizha1 yizha1 self-assigned this Oct 11, 2022
@yizha1 yizha1 added cli Issue or PR released to Notation CLI spec Specifications to define the product requirements labels Oct 11, 2022
@yizha1 yizha1 linked an issue Oct 11, 2022 that may be closed by this pull request
Signed-off-by: Yi Zha <zhayi@outlook.com>
@yizha1 yizha1 requested review from dtzar and priteshbandi October 14, 2022 09:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #376 (5c3b110) into main (6e8e9c5) will increase coverage by 1.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   30.54%   32.03%   +1.49%     
==========================================
  Files          25       26       +1     
  Lines        1614     1670      +56     
==========================================
+ Hits          493      535      +42     
- Misses       1108     1122      +14     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/push.go 21.91% <0.00%> (-2.70%) ⬇️
internal/cmd/flags.go 52.74% <0.00%> (-1.80%) ⬇️
internal/cmd/signer.go 0.00% <0.00%> (ø)
internal/cmd/options.go 0.00% <0.00%> (ø)
cmd/notation/cert_gen.go 0.00% <0.00%> (ø)
internal/envelope/envelope.go 100.00% <0.00%> (ø)
cmd/notation/verify.go 26.89% <0.00%> (+8.26%) ⬆️
cmd/notation/sign.go 42.45% <0.00%> (+12.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one feedback. Please incorporate before pushing change.

Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 07bba5f into notaryproject:main Oct 18, 2022
@yizha1 yizha1 deleted the spec-verify branch October 18, 2022 10:30
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
Add spec for `notation version` command.

Signed-off-by: Yi Zha <zhayi@outlook.com>
FeynmanZhou pushed a commit to FeynmanZhou/notation that referenced this pull request May 15, 2025
Add spec for `notation version` command.

Signed-off-by: Yi Zha <zhayi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issue or PR released to Notation CLI spec Specifications to define the product requirements

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add version command for notation CLI

5 participants