spec: add CLI notation certificate and key specs#361
Merged
priteshbandi merged 22 commits intonotaryproject:mainfrom Oct 19, 2022
Merged
spec: add CLI notation certificate and key specs#361priteshbandi merged 22 commits intonotaryproject:mainfrom
priteshbandi merged 22 commits intonotaryproject:mainfrom
Conversation
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
yizha1
requested review from
FeynmanZhou,
binbin-li,
dtzar,
gokarnm,
iamsamirzon,
patrickzheng200,
priteshbandi and
shizhMSFT
yizha1
changed the title
Signed-off-by: Yi Zha <zhayi@outlook.com>
binbin-li
reviewed
Sep 29, 2022
patrickzheng200
suggested changes
Sep 29, 2022
binbin-li
reviewed
Sep 29, 2022
This was referenced Oct 1, 2022
Closed
Signed-off-by: Yi Zha <zhayi@outlook.com>
priteshbandi
reviewed
Oct 7, 2022
priteshbandi
reviewed
Oct 7, 2022
shizhMSFT
reviewed
Oct 9, 2022
| -d, --default mark as default | ||
| -h, --help help for generate-test | ||
| -n, --name string key and certificate name | ||
| --trust add the generated certificate to the trust store |
Contributor
There was a problem hiding this comment.
Since we have trust policy and trust store, we need to elaborate what --trust means.
Contributor
Author
There was a problem hiding this comment.
I think the description is clear for --trust. Do you mean we need to change the name of --trust for trust store only? For example --trust-store?
Contributor
Author
There was a problem hiding this comment.
This flag only adds the generated certificate to the trust stone, no operations on trust policy.
Signed-off-by: Yi Zha <zhayi@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 30.54% 32.03% +1.49%
==========================================
Files 25 26 +1
Lines 1614 1670 +56
==========================================
+ Hits 493 535 +42
- Misses 1108 1122 +14
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Yi Zha <zhayi@outlook.com>
gokarnm
reviewed
Oct 10, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
patrickzheng200
suggested changes
Oct 13, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
patrickzheng200
suggested changes
Oct 17, 2022
Signed-off-by: Yi Zha <zhayi@outlook.com>
Signed-off-by: Yi Zha <zhayi@outlook.com>
| Update key in signing key list | ||
|
|
||
| Usage: | ||
| notation key update [flags] <key_name> |
Contributor
There was a problem hiding this comment.
Whats the purpose/ intended use of update command? Is it just to update default key? if so, the --default flag becomes mandatory here.
Also, if it its only for updating default key, should we rename it to update-default ?
Contributor
Author
There was a problem hiding this comment.
Currently only one flag '--default', there could be more later.
Signed-off-by: Yi Zha <zhayi@outlook.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Yi Zha <zhayi@outlook.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Signed-off-by: Yi Zha <zhayi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.