Skip to content

fix: deprecated the expiry flag of notation cert generate-test#313

Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom
patrickzheng200:rmvExpiry
Sep 1, 2022
Merged

fix: deprecated the expiry flag of notation cert generate-test#313
shizhMSFT merged 1 commit intonotaryproject:mainfrom
patrickzheng200:rmvExpiry

Conversation

@patrickzheng200
Copy link
Copy Markdown
Contributor

removed the expiry flag of 'notation cert generate-test' command

Resolves #312

Signed-off-by: Patrick Zheng patrickzheng@microsoft.com

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #313 (99c4520) into main (e73bfc3) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   30.66%   30.62%   -0.05%     
==========================================
  Files          25       25              
  Lines        1611     1610       -1     
==========================================
- Hits          494      493       -1     
  Misses       1104     1104              
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/cert.go 35.29% <ø> (-0.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT requested review from a team August 25, 2022 02:13
@shizhMSFT shizhMSFT added this to the RC-1 milestone Aug 25, 2022
@patrickzheng200 patrickzheng200 changed the title deprecated the expiry flag of notation cert generate-test fix: deprecated the expiry flag of notation cert generate-test Aug 25, 2022
Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shizhMSFT shizhMSFT merged commit 6dd40fb into notaryproject:main Sep 1, 2022
@patrickzheng200 patrickzheng200 deleted the rmvExpiry branch September 26, 2022 03:42
@vaninrao10 vaninrao10 modified the milestones: RC-1, alpha-4 Sep 29, 2022
7h3-3mp7y-m4n pushed a commit to 7h3-3mp7y-m4n/notation that referenced this pull request Mar 29, 2025
…ect#313)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove unused options for notation cert generate-test

5 participants