fix: allow empty credentials store config#286
Merged
gokarnm merged 1 commit intonotaryproject:mainfrom Aug 9, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 61.73% 61.07% -0.67%
==========================================
Files 9 9
Lines 277 280 +3
==========================================
Hits 171 171
- Misses 100 102 +2
- Partials 6 7 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
force-pushed
the
fix/allow_empty_credentials
branch
from
62fa8a9 to
d7e3b2d
Compare
|
Thank you @FeynmanZhou for finding this, @JeyJeyGao for the quick fix turnaround, and quick review from @gokarnm @binbin-li @shizhMSFT 👍 |
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backgroud: according to previous design, credentials store config must exist in notation config.json or docker config.json, but you may not need a credentials store config to sign image for local registry.
Fix: we need to allow empty credentials store config for local reigistry.
Test:
Resolves #284
Signed-off-by: Junjie Gao junjiegao@microsoft.com