Directory Structure Implementation#265
Merged
shizhMSFT merged 1 commit intonotaryproject:mainfrom Aug 5, 2022
Merged
Conversation
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
from
1f5d78b to
d049d65
Compare
JeyJeyGao
changed the title
JeyJeyGao
changed the title
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
from
d049d65 to
c09b0c4
Compare
binbin-li
reviewed
Jul 27, 2022
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
3 times, most recently
from
134566e to
464b26d
Compare
5 tasks
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
3 times, most recently
from
6cafdab to
7a3ba80
Compare
JeyJeyGao
changed the title
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
from
7a3ba80 to
e72f022
Compare
|
Per the PR review criteria @notaryproject/notation-sub-group-maintainers - this is past a week old and has two approvals from official code-reviewers, so it is eligible for merge now. |
shizhMSFT
reviewed
Aug 4, 2022
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
from
e72f022 to
af09540
Compare
shizhMSFT
requested changes
Aug 4, 2022
1. support dir package 2. supoort notation-go/config package Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
JeyJeyGao
force-pushed
the
feat/directory_struct
branch
from
af09540 to
a181c2c
Compare
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
1. support dir package 2. supoort notation-go/config package Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test:
tested with the workflow mentioned in hello-signing
notation cert generate-test --default "wabbit-networks.io"notation --plain-http sign $IMAGEnotation --plain-http list $IMAGEnotation --plain-http verify $IMAGEnotation cache listnotation plugin listnotation pull $IMAGEnotation push $IMAGEnotation key listnotation cert add --name "wabbit-networks.io" ~/.config/notation/localkeys/wabbit-networks.io.crtSigned-off-by: Junjie Gao 43160897+JeyJeyGao@users.noreply.github.com