feat: bump up notation-go to latest version#248
Merged
gokarnm merged 2 commits intonotaryproject:mainfrom Jul 13, 2022
Merged
Conversation
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li
force-pushed
the
bump-up-notation-go
branch
from
450c6d0 to
a90deff
Compare
priteshbandi
approved these changes
Jul 13, 2022
Contributor
priteshbandi
left a comment
priteshbandi
left a comment
There was a problem hiding this comment.
LGTM
Once this PR is merged, we can close #234
Closed
2 tasks
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
* feat: bump up notation-go to latest version Signed-off-by: Binbin Li <libinbin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix the build failure due to the breaking change in
notation-goas #247 mentioned.Related changes in
notation-go:notaryproject/notation-go#77
notaryproject/notation-go#67
notaryproject/notation-go#64
Test
go clean -modcache && go mod tidySigned-off-by: Binbin Li libinbin@microsoft.com