feat!: add signingkeys.json validation check#246
Merged
priteshbandi merged 16 commits intonotaryproject:mainfrom Feb 3, 2023
Merged
feat!: add signingkeys.json validation check#246priteshbandi merged 16 commits intonotaryproject:mainfrom
priteshbandi merged 16 commits intonotaryproject:mainfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 73.35% 69.56% -3.79%
==========================================
Files 23 23
Lines 1775 1909 +134
==========================================
+ Hits 1302 1328 +26
- Misses 375 483 +108
Partials 98 98
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
byronchien
approved these changes
Jan 23, 2023
JeyJeyGao
reviewed
Jan 28, 2023
priteshbandi
force-pushed
the
signingkey-fix
branch
from
efa37bf to
29fb75a
Compare
priteshbandi
force-pushed
the
signingkey-fix
branch
2 times, most recently
from
cef7edd to
a0e70c8
Compare
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Fix error message: Instead of printing bytes in error message convert them to string. Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
This PR adds examples for notation-go sign and verify including fully functional examples (can run in go playground) for local sign and local verify. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
…ryproject#248) Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
notaryproject#247) Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi
force-pushed
the
signingkey-fix
branch
from
f908baf to
b470363
Compare
patrickzheng200
approved these changes
Feb 1, 2023
Contributor
patrickzheng200
left a comment
patrickzheng200
left a comment
There was a problem hiding this comment.
LGTM. We could wait for Shiwei in case he has extra comments on the PR.
shizhMSFT
changed the title
shizhMSFT
reviewed
Feb 2, 2023
priteshbandi
added a commit
to priteshbandi/notation-go
that referenced
this pull request
Feb 3, 2023
Change to validate signingkeys are valid(unique name) for both read and write operation. Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi
added a commit
to notaryproject/notation
that referenced
this pull request
Feb 3, 2023
This PR depends on notaryproject/notation-go#246 so please review notaryproject/notation-go#246 first. Signed-off-by: Pritesh Bandi <pritesb@amazon.com
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
This PR depends on notaryproject/notation-go#246 so please review notaryproject/notation-go#246 first. Signed-off-by: Pritesh Bandi <pritesb@amazon.com
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
This PR depends on notaryproject/notation-go#246 so please review notaryproject/notation-go#246 first. Signed-off-by: Pritesh Bandi <pritesb@amazon.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to validate signingkeys are valid(unique name) for both read and write operation.
Signed-off-by: Pritesh Bandi pritesb@amazon.com