fix: requeue h2 requests after goaway#5473
Merged
Merged
Conversation
Detach all GOAWAY-affected HTTP/2 request streams before closing any of them so synchronous frameError fallout from the old session cannot abort requests that should be retried. Ignore stale session, socket, and connection-level frame errors once a GOAWAY has started detaching and requeueing requests. Fixes: #5468 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5473 +/- ##
==========================================
- Coverage 93.46% 93.45% -0.01%
==========================================
Files 110 110
Lines 37115 37149 +34
==========================================
+ Hits 34690 34719 +29
- Misses 2425 2430 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frameErrorevents cannot fail requests that should be requeuedGOAWAYFixes: #5468
Tests
npm run lint -- test/http2-goaway.js lib/dispatcher/client-h2.jsnode --test test/http2-goaway.jsnpm run test:h2:core