This repository was archived by the owner on May 13, 2019. It is now read-only.
Revert "coverage: remove folder"#58
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:revert-57-jm-rm-coverage
Closed
Revert "coverage: remove folder"#58maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:revert-57-jm-rm-coverage
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:revert-57-jm-rm-coverage
Conversation
This reverts commit 5d85de3.
Member
|
Landing now. |
mhdawson
pushed a commit
that referenced
this pull request
Jan 4, 2018
Member
|
Landed as 56fffa6 Sorry for not being clearer earlier about some of the dependencies. I'm just testing the PR to check updating master to use the files from the build repo instead and will CC you when I submit it. |
Member
|
@maclover7 nodejs/node#17987 PR to update paths in master. Once that lands I'll also need to update the coverage jenkins job as it relies on the old path as well. We'll then likely want to backport the PR to earlier streams were we have coverage support built in and then we can delete these files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #57
nodejs/node depends on the files, so needs to be temporarily reverted until references can be updated
@mhdawson