[Fix] babel's "loose mode" class transform enbrittles BufferList

[ljharb]

Object.defineProperty(Object.prototype, util.inspect.custom, {
  set(v) { throw 'this should not happen inside readable-stream'; }
});

With this change, I believe the output will use [[Define]] instead of [[Set]] for https://github.com/nodejs/node/blob/c101251a95cc82142bee4637f8db6cc360a06d82/lib/internal/streams/buffer_list.js#L167, and thus no longer fail when Object.prototype is modified.

[ljharb]

Seems like vweevers@432d4b7 is when it first was put into loose mode, in #299, due to #293.

Does readable-stream still support pre-ES5 environments? #344 implies that it does not.

[mcollina]

We support IE11 in readable-stream v3, while we still support pre-es5 environments in v2. This can land but not be backported.

[mcollina]

Can you also regenerate the code?

cd build
node build.js v10.19.0

[ljharb]

just v3 is fine; I’m mainly concerned with the version of this that’s vendored in core; that one doesn’t need to run Babel at all :-)

will update the build shortly

[mcollina]

lgtm

[mcollina]

cc @vweevers what do you think?

[vweevers]

👍

[ljharb]

yay! what are the next steps to get this into core?

[mcollina]

I think you'll have to wait for npm to do a release, and then update core to that. Or you can force a replacement directly.

[ljharb]

done in npm/cli#824 and nodejs/node#31977