fix isInteger for IE11#389
Merged
mcollina merged 1 commit intonodejs:masterfrom Dec 13, 2018
TankerHQ:master
Merged
Conversation
mcollina
reviewed
Dec 12, 2018
package.json
Outdated
| "babel-plugin-transform-es2015-spread": "^6.22.0", | ||
| "babel-plugin-transform-es2015-template-literals": "^6.8.0", | ||
| "babel-plugin-transform-inline-imports-commonjs": "^1.2.0", | ||
| "babel-plugin-transform-optional-catch-binding": "^7.0.0-alpha.16", |
Member
There was a problem hiding this comment.
I'm not really confident in depending on alpha code. Is there a stable version of this transform?
Member
There was a problem hiding this comment.
You'd probably have to migrate everything to babel 7 stable (under the @babel/ namespace. This tool can help: https://github.com/babel/babel-upgrade
Contributor
Author
There was a problem hiding this comment.
I don't see any stable version on npm and the latest one is already one year old.
Anyway this package is only necessary to build readable-stream from scratch. And so is not relevant to the fix.
I'll just drop the commit adding the dependency and create an issue (#392) to upgrade to babel 7 stable as @targos said.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes usage of
Number.isIntegerinlib/internal/streams/state.jsintegerIE11rule inbuild/files.jsbabel-plugin-transform-optional-catch-binding(so that anyone can run ./build/build.js)Fix #390