nina 2016 code-n-learn, issue: use assert.Equal() by ianwhitedeveloper · Pull Request #9977 · nodejs/node

ianwhitedeveloper · 2016-12-01T17:04:46Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Test

Description of change

test: change assert.equal to assert.strictEqual

the following lines have been updated:

27:1
37:1
49:1
61:3
66:1
79:1

imyller · 2016-12-01T17:06:08Z

@ianwhitedeveloper May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

ianwhitedeveloper · 2016-12-01T17:10:36Z

mad bad @imyller and @mscdex. I have updated my commit message. Thanks for taking a look!
Also, I'm sharing a computer with a co-worker. Will have him push an amended commit ASAP.

nina 2016

ianwhitedeveloper · 2016-12-01T17:27:44Z

Alrighty just pushed an amended commit. Thanks again.

imyller · 2016-12-01T17:32:37Z

@ianwhitedeveloper Looks great! Thank you 👍

gibfahn · 2016-12-01T18:24:38Z

@ianwhitedeveloper FYI, your commit has the name cdnadmin (email: cdnadmin@collaborare.net). If you want to change that to your name and email, you probably want to do something like:

git commit --amend --no-edit --author="Ian White <ian.white.developer@gmail.com>"

And then update your branch (which will update this PR).

cjihrig · 2016-12-01T19:15:09Z

test/parallel/test-fs-append-file-sync.js


-assert.equal(Buffer.byteLength(data) + currentFileData.length,
+assert.strictEqual(Buffer.byteLength(data) + currentFileData.length,
             fileData2.length);


This needs to be lined up now.

cjihrig · 2016-12-01T19:15:28Z

test/parallel/test-fs-append-file-sync.js


-assert.equal(Buffer.byteLength('' + num) + currentFileData.length,
+assert.strictEqual(Buffer.byteLength('' + num) + currentFileData.length,
             fileData4.length);


cjihrig · 2016-12-01T19:15:37Z

test/parallel/test-fs-append-file-sync.js


-assert.equal(Buffer.byteLength(data) + currentFileData.length,
+assert.strictEqual(Buffer.byteLength(data) + currentFileData.length,
             fileData5.length);


ianwhitedeveloper · 2016-12-02T14:59:35Z

Alrighty @cjihrig I'll make those updates ASAP. Having problems with my computer so I'm going to need to clear a bunch of space to get the project up and running, but it's on my radar! thanks for taking a look.

ianwhitedeveloper · 2016-12-02T16:03:08Z

Ok @cjihrig I made the changes. Hopefully I didn't misunderstand the problem! Thanks again!

cjihrig

Thanks! Code changes LGTM.

cjihrig · 2016-12-02T17:02:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5109/

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott · 2016-12-04T05:08:58Z

Landed in 62f4b77. Thanks for the contribution! 🎉

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016

imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016

mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 1, 2016

test: change asset.equal to assert.strictEqual

76f28a8

nina 2016

ianwhitedeveloper force-pushed the use-assert-equal branch from dbd6e32 to 76f28a8 Compare December 1, 2016 17:27

cjihrig requested changes Dec 1, 2016

View reviewed changes

fix code alignment

a66cd9a

cjihrig approved these changes Dec 2, 2016

View reviewed changes

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016

test: refactor test-fs-append-file-sync

62f4b77

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott closed this Dec 4, 2016

addaleax pushed a commit that referenced this pull request Dec 5, 2016

test: refactor test-fs-append-file-sync

070370f

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 mentioned this pull request Dec 5, 2016

v7.2.1 proposal #10127

Merged

2 tasks

addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016

test: refactor test-fs-append-file-sync

61225ea

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016

test: refactor test-fs-append-file-sync

99f05ca

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: nodejs#9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added the land-on-v6.x label Dec 8, 2016

MylesBorins added the dont-land-on-v4.x label Dec 20, 2016

MylesBorins pushed a commit that referenced this pull request Dec 21, 2016

test: refactor test-fs-append-file-sync

53db317

Change instances of `asset.equal` to `assert.strictEqual`. PR-URL: #9977 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins mentioned this pull request Dec 21, 2016

V6.9.3 proposal #10394

Merged

Uh oh!

Conversation

ianwhitedeveloper commented Dec 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

imyller commented Dec 1, 2016

Uh oh!

ianwhitedeveloper commented Dec 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianwhitedeveloper commented Dec 1, 2016

Uh oh!

imyller commented Dec 1, 2016

Uh oh!

gibfahn commented Dec 1, 2016

Uh oh!

cjihrig Dec 1, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig Dec 1, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig Dec 1, 2016

Choose a reason for hiding this comment

Uh oh!

ianwhitedeveloper commented Dec 2, 2016

Uh oh!

ianwhitedeveloper commented Dec 2, 2016

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Dec 2, 2016

Uh oh!

Trott commented Dec 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ianwhitedeveloper commented Dec 1, 2016 •

edited

Loading

ianwhitedeveloper commented Dec 1, 2016 •

edited

Loading