test: replace var with const/let and use common.mustCall for cb#9959
Closed
outsideris wants to merge 1 commit intonodejs:masterfrom
Closed
test: replace var with const/let and use common.mustCall for cb#9959outsideris wants to merge 1 commit intonodejs:masterfrom
outsideris wants to merge 1 commit intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
Contributor
princejwesley
left a comment
princejwesley
left a comment
There was a problem hiding this comment.
Merge commits as single commit!
outsideris
force-pushed
the
code-and-learn-1
branch
from
92d4a6e to
fff2a4a
Compare
Contributor
Author
|
@princejwesley I merged them. |
cjihrig
approved these changes
Dec 5, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with one small nit.
Contributor
There was a problem hiding this comment.
Can you move this line below the hasCrypto check?
jasnell
approved these changes
Dec 5, 2016
Member
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
outsideris
force-pushed
the
code-and-learn-1
branch
from
fff2a4a to
1c38ce2
Compare
Contributor
Author
|
As @cjihrig said, I moved the require statement. |
Member
silverwind
approved these changes
Dec 16, 2016
Contributor
|
Thanks! Landed with slightly trimmed commit message in 4913acd. |
silverwind
pushed a commit
that referenced
this pull request
Dec 16, 2016
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
Author
|
@silverwind Thanks! |
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
remove process.on('exit') because all callbacks are
wrapped by common.mustCall.
PR-URL: #9959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
common.mustCallfor callbacksprocess.on('exit')because all callbacks are wrapped bycommon.mustCall