test: refactor to const/let and common.mustCall#9934
Conversation
imyller
added
the
code-and-learn
cjihrig
reviewed
Dec 4, 2016
Contributor
There was a problem hiding this comment.
common.mustCall() takes an optional second argument that specifies the number of times the function should be called. You could use that here, and then completely remove the process.on('exit', ...) block.
Author
|
adjusted |
cjihrig
reviewed
Dec 5, 2016
Contributor
There was a problem hiding this comment.
I don't think you can drop this check. It changes the behavior. The server will be closed the first time instead of the second.
refactor var -> const/let
refactor process.on('exit') into common.mustCall
Author
|
adjusted |
jasnell
approved these changes
Dec 5, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM pending CI (will run the CI soon, just waiting for other jobs to finish)
Member
Member
|
Single CI failure is unrelated. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 6, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d648f2b. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
refactor var -> const/let
refactor process.on('exit') into common.mustCall
PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: refactor to const/let and common.mustCall
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
task assigned at NINA 2016 Austin code and learn
refactor var -> const/let
refactor process.on('exit') into common.mustCall