Skip to content

test: update test to assert require() and es6ify variables#9912

Closed
DarylThayil wants to merge 1 commit intonodejs:masterfrom
DarylThayil:require-test-improve
Closed

test: update test to assert require() and es6ify variables#9912
DarylThayil wants to merge 1 commit intonodejs:masterfrom
DarylThayil:require-test-improve

Conversation

@DarylThayil
Copy link

@DarylThayil DarylThayil commented Dec 1, 2016 •
edited
Loading

Checklist
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Tests

Description of change

Code and Learn change for test-require-extensions-main.js

  • var => const
  • assert test fixtures

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

This needs to have a more descriptive commit message and it should start with a test: prefix.

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@DarylThayil DarylThayil changed the title update test file for first commit test: update test to assert require() and es6ify variables Dec 1, 2016
@DarylThayil
Copy link
Author

DarylThayil commented Dec 1, 2016

updated description @mscdex

@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016 •
edited
Loading

@DarylThayil That updated the PR title, but not the actual commit message.

@DarylThayil
Copy link
Author

DarylThayil commented Dec 1, 2016

ahh yes! @mscdex should have got it now thanks

@gibfahn
Copy link
Member

gibfahn commented Dec 2, 2016

@DarylThayil It's still over 50 chars, maybe something like:

test: refactor test-require-extensions-main

* var => const
* assert test fixtures

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5201/

jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is good.

@darylthayilporch
test: refactor test-require-extensions-main
0694bb3 
* var => const
* assert test fixtures
@DarylThayil
Copy link
Author

DarylThayil commented Dec 5, 2016

@mscdex sorry, updated now
@jasnell if lgtm will someone else merge for me ?

fhinkel
fhinkel approved these changes Dec 6, 2016
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Yes, we'll merge it for you :)

jasnell pushed a commit that referenced this pull request Dec 6, 2016
@darylthayilporch @jasnell
test: refactor test-require-extensions-main
81661a7 
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

Landed in 81661a7. Thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@darylthayilporch @Fishrock123
test: refactor test-require-extensions-main
2f6d0c7 
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@darylthayilporch @addaleax
test: refactor test-require-extensions-main
d64cb1e 
* var => const
* assert test fixtures

PR-URL: nodejs#9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@darylthayilporch
test: refactor test-require-extensions-main
66eb6dc 
* var => const
* assert test fixtures

PR-URL: nodejs#9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@darylthayilporch @MylesBorins
test: refactor test-require-extensions-main
ce14c1e 
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@darylthayilporch @MylesBorins
test: refactor test-require-extensions-main
009bbde 
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@darylthayilporch @MylesBorins
test: refactor test-require-extensions-main
3f20246 
* var => const
* assert test fixtures

PR-URL: #9912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@DarylThayil @mscdex @gibfahn @jasnell @fhinkel @MylesBorins @addaleax @imyller @nodejs-github-bot @darylthayilporch