Skip to content

test: Update test to new conventions#9907

Closed
stv8 wants to merge 1 commit intonodejs:masterfrom
stv8:var_to_const_in_tests
Closed

test: Update test to new conventions#9907
stv8 wants to merge 1 commit intonodejs:masterfrom
stv8:var_to_const_in_tests

Conversation

@stv8
Copy link
Contributor

@stv8 stv8 commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test
Description of change
  • var -> const
  • assert.equal -> assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Dec 1, 2016
princejwesley
princejwesley approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@princejwesley princejwesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove * task 68 in the nina code and learn and add commit msg like
test: var to const, assert.equal to assert.strictEqual in net

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@stv8 stv8 force-pushed the var_to_const_in_tests branch from 7d6f427 to 7e77f26 Compare December 1, 2016 16:30
@stv8
Copy link
Contributor Author

stv8 commented Dec 1, 2016

@princejwesley commit message changed

@stv8
test: var to const, assert.equal to assert.strictEqual in net
2531679 
* var -> const
* assert.equal -> assert.strictEqual
@stv8 stv8 force-pushed the var_to_const_in_tests branch from 7e77f26 to 2531679 Compare December 1, 2016 16:32
@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5089/

@stv8
Copy link
Contributor Author

stv8 commented Dec 2, 2016

@Trott What is the procedure for restarting this build?

@addaleax
Copy link
Member

addaleax commented Dec 2, 2016

New CI: https://ci.nodejs.org/job/node-test-commit/6321/

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@stv8 @jasnell
test: var to const, assert.equal to assert.strictEqual in net
f7f2102 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: #9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in f7f2102. Thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 5, 2016
@stv8 stv8 deleted the var_to_const_in_tests branch December 5, 2016 04:01
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@stv8 @Fishrock123
test: var to const, assert.equal to assert.strictEqual in net
65c4483 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: #9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@stv8 @addaleax
test: var to const, assert.equal to assert.strictEqual in net
2127798 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: nodejs#9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@stv8
test: var to const, assert.equal to assert.strictEqual in net
14a4e8c 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: nodejs#9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@stv8 @MylesBorins
test: var to const, assert.equal to assert.strictEqual in net
ae9e2a2 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: #9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@stv8 @MylesBorins
test: var to const, assert.equal to assert.strictEqual in net
91133d0 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: #9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@stv8 @MylesBorins
test: var to const, assert.equal to assert.strictEqual in net
65251e5 
* var -> const
* assert.equal -> assert.strictEqual

PR-URL: #9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@princejwesley princejwesley princejwesley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@stv8 @Trott @addaleax @jasnell @princejwesley @cjihrig @mscdex @MylesBorins @imyller @nodejs-github-bot