test: refactor test-child-process-stdio-inherit#9893
Closed
WesTyler wants to merge 1 commit intonodejs:masterfrom
xogroup:test_child_process
Closed
test: refactor test-child-process-stdio-inherit#9893WesTyler wants to merge 1 commit intonodejs:masterfrom xogroup:test_child_process
WesTyler wants to merge 1 commit intonodejs:masterfrom
xogroup:test_child_process
Conversation
* assert.equal() -> assert.strictEqual()
mscdex
added
the
child_process
imyller
added
the
code-and-learn
Member
santigimeno
approved these changes
Dec 1, 2016
cjihrig
approved these changes
Dec 3, 2016
lpinca
approved these changes
Dec 3, 2016
Contributor
Author
|
Is it normal for a CI check to be pending for this long? Navigating into the details of |
jasnell
approved these changes
Dec 4, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM! thank you for the PR and for participating in the code-and-learn!
Member
|
@WesTyler ... the CI gets tied up from time to time. The failure is unrelated to this PR. |
jasnell
pushed a commit
that referenced
this pull request
Dec 4, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 948ee11. Thank you! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
assert.equal() -> assert.strictEqual() PR-URL: nodejs#9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
assert.equal() -> assert.strictEqual() PR-URL: #9893 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change