test: var to const/let in test-tls-set-ciphers#9877
Closed
rajatkumar wants to merge 1 commit intonodejs:masterfrom
rajatkumar:fix-test-tls-set-ciphers
Closed
test: var to const/let in test-tls-set-ciphers#9877rajatkumar wants to merge 1 commit intonodejs:masterfrom rajatkumar:fix-test-tls-set-ciphers
rajatkumar wants to merge 1 commit intonodejs:masterfrom
rajatkumar:fix-test-tls-set-ciphers
Conversation
Member
|
@rajatkumar May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
Member
cjihrig
approved these changes
Dec 1, 2016
this change is part of code and learn (NINA-2016)
rajatkumar
changed the title
imyller
added
the
code-and-learn
Contributor
Author
|
@imyller I have ammended the commit message and also updated the PRs comment. Please let me know if this looks fine. |
princejwesley
approved these changes
Dec 1, 2016
Member
|
@rajatkumar Looks great! 👍 |
Contributor
Author
|
@imyller how do we re-run the ci tests? |
lpinca
approved these changes
Dec 2, 2016
targos
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 3, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the PR and for participating in Code and Learn! Welcome to Node.js :-)
Member
|
Failures appear to be unrelated |
jasnell
pushed a commit
that referenced
this pull request
Dec 4, 2016
this change is part of code and learn (NINA-2016) PR-URL: #9877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 639ddcb. thank you! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
this change is part of code and learn (NINA-2016) PR-URL: #9877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
this change is part of code and learn (NINA-2016) PR-URL: nodejs#9877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
this change is part of code and learn (NINA-2016) PR-URL: nodejs#9877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
this change is part of code and learn (NINA-2016) PR-URL: #9877 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
this change is part of code and learn (NINA-2016)