lib: use strict equality in _http_server and _tls_wrap#9849
Closed
walterbm wants to merge 1 commit intonodejs:masterfrom
walterbm:lib-favor-strict-equality
Closed
lib: use strict equality in _http_server and _tls_wrap#9849walterbm wants to merge 1 commit intonodejs:masterfrom walterbm:lib-favor-strict-equality
walterbm wants to merge 1 commit intonodejs:masterfrom
walterbm:lib-favor-strict-equality
Conversation
nodejs-github-bot
added
http
Trott
approved these changes
Nov 30, 2016
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is ✅
If you can, could you change the commit message first line to be no more than 50 chars? Maybe something like lib: use === in _http_server and _tls_wrap
Member
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion.
Contributor
Author
|
@Trott changed the first line of commit message first line to be less than 50 characters. Seems like CI is failing for the ARM build of Node but I'm having some trouble locating the error. Looking through the Jenkins console log I can see a build failure but I'm not sure if that is the root cause. I couldn't find any failing tests. |
Member
Member
|
This is the output for the failure: https://ci.nodejs.org/job/node-test-binary-arm/4915/RUN_SUBSET=addons,label=pi1-raspbian-wheezy/console Looks unrelated to change being made here. |
Member
|
Rerun of CI was green! |
cjihrig
approved these changes
Nov 30, 2016
targos
approved these changes
Dec 1, 2016
lpinca
approved these changes
Dec 1, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 3, 2016
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: nodejs#9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: #9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: nodejs#9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: #9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: #9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
lib/_http_server
lib/_tls_wrap
Description of change
Minor fix to favor strict equality in http_server.js and tls_wrap.js
to ensure accurate comparisons without type coercion.