Closed
Conversation
fix crypto "Verify" typo I am currently translating doc into Chinese, but I found this problem in the translation process.
nodejs-github-bot
added
crypto
addaleax
approved these changes
Nov 25, 2016
doc/api/crypto.md
Outdated
|
|
||
| The [`crypto.createSign()`][] method is used to create `Sign` instances. | ||
| `Sign` objects are not to be created directly using the `new` keyword. | ||
| The [`crypto.createVerify()`][] method is used to create `Verify` instances. `Verify` |
Member
There was a problem hiding this comment.
Can you try to wrap lines at 80 columns? Thank you :)
I'm sorry, I did not realize this before.
cjihrig
approved these changes
Nov 25, 2016
Contributor
|
LGTM |
mhdawson
approved these changes
Nov 25, 2016
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
Commit message should start with
"doc: "
ie:
doc: fix crypto "Verify" typo
Otherwise LGTM once thats fixedup.
Contributor
|
I can squash and rewrite the commit message when I land this, or @Amery2010 can do it, but I'm supposed to wait two working days, which means not merging until Monday :-(. Maybe there is a dispensation for such trivially correct improvements, such as this one? |
Member
|
@sam-github I saw some trivial changes like typos being landed without waiting the 48/72 hours. |
lpinca
approved these changes
Nov 25, 2016
princejwesley
approved these changes
Nov 25, 2016
Contributor
|
Landed in 630c63e |
sam-github
pushed a commit
that referenced
this pull request
Nov 25, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Contributor
|
@Amery2010 I rewrote your commit message. Please take a look, I'm sure you will need to PR more improvements to docs if you are translating, because you will see many errors. |
Member
|
Agreed that fixing in commit message is ok, but important @Amery2010 is aware for the next time. |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Verify documentation had cut-n-pasted documentation from Sign. PR-URL: #9796 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
fix crypto "Verify" typo
I am currently translating doc into Chinese, but I found this problem in the translation process.