doc: add guide for maintaining V8 by ofrobots · Pull Request #9777 · nodejs/node

ofrobots · 2016-11-24T01:53:20Z

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

This document attempts to describe the processes for maintaining the V8 brances in Node.js LTS and Current releases.

Previously: nodejs/Release#137

mhdawson

LGTM with nit

mhdawson · 2016-11-24T16:41:49Z

doc/guides/maintaining-V8.md

"now the broweser" should be "not the browser"

sam-github · 2016-11-24T16:47:56Z

doc/guides/maintaining-V8.md

authors? people to ask for help? something else?

It was authors, but I have removed that line.

sam-github · 2016-11-24T16:50:04Z

doc/guides/maintaining-V8.md

"If the" -> "The"?

sam-github · 2016-11-24T16:51:01Z

doc/guides/maintaining-V8.md

is this different from backporting to active branches? doesn't v8 backport to active?

I have tried to clarify this a bit further. The idea was that there are three classes of bugs, Node.js bugs that have (1) or have not (2) been fixed upstream, and bugs that have not been encountered by Node.js yet but upstream has identified as potentially interesting to Node (3).

sam-github · 2016-11-24T16:52:25Z

doc/guides/maintaining-V8.md

where is this branch? I don't see it in nodejs/node.

Thanks. Added link. FYI, it is at https://github.com/v8/node/tree/vee-eight-lkgr but we can bring this over to nodejs/node too if it is helpful.

sam-github · 2016-11-24T16:54:46Z

doc/guides/maintaining-V8.md

"into V8 5.1"

sam-github · 2016-11-24T16:56:04Z

doc/guides/maintaining-V8.md

v6.x-staging is just an example, right? because backports might be necessary to any LTS staging branch

sam-github · 2016-11-24T16:57:44Z

doc/guides/maintaining-V8.md

trace_event, or trace_event.h?

trace event is a component. gtest_prod.h is just a file.

targos · 2016-11-24T18:29:51Z

doc/guides/maintaining-V8.md

after V8 5.4 shipped as stable.

Ref: nodejs/Release#137

ofrobots · 2016-11-28T20:11:12Z

I will land this later today.

ofrobots · 2016-11-29T00:19:35Z

Thanks. Landed as 11b0872.

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 24, 2016

ofrobots mentioned this pull request Nov 24, 2016

Add doc on maintaining V8 in Node nodejs/Release#137

Closed

mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Nov 24, 2016

mhdawson approved these changes Nov 24, 2016

View reviewed changes

doc/guides/maintaining-V8.md Outdated

Copy link

Member

mhdawson Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"now the broweser" should be "not the browser"

ofrobots reacted with thumbs up emoji

sam-github reviewed Nov 24, 2016

View reviewed changes

doc/guides/maintaining-V8.md Outdated

Copy link

Contributor

sam-github Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If the" -> "The"?

ofrobots reacted with thumbs up emoji

sam-github reviewed Nov 24, 2016

View reviewed changes

doc/guides/maintaining-V8.md Outdated

Copy link

Contributor

sam-github Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"into V8 5.1"

ofrobots reacted with thumbs up emoji

sam-github reviewed Nov 24, 2016

View reviewed changes

targos approved these changes Nov 24, 2016

View reviewed changes

doc/guides/maintaining-V8.md Outdated

Copy link

Member

targos Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after V8 5.4 shipped as stable.

ofrobots reacted with thumbs up emoji

doc: add guide for maintaining V8

f07f5c2

Ref: nodejs/Release#137

ofrobots force-pushed the maintaining-v8 branch from 0983c42 to f07f5c2 Compare November 26, 2016 15:43

MylesBorins mentioned this pull request Nov 28, 2016

deps: backport fix to v8 bug in toUpper('ç') #9828

Closed

3 tasks

ofrobots closed this Nov 29, 2016

ofrobots deleted the maintaining-v8 branch November 29, 2016 00:19

ofrobots added a commit that referenced this pull request Nov 29, 2016

doc: add guide for maintaining V8

11b0872

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

addaleax pushed a commit that referenced this pull request Dec 5, 2016

doc: add guide for maintaining V8

6ab920a

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

Fishrock123 mentioned this pull request Dec 5, 2016

v7.2.1 proposal #10127

Merged

2 tasks

MylesBorins pushed a commit that referenced this pull request Dec 13, 2016

doc: add guide for maintaining V8

cf131bf

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

MylesBorins added land-on-v4.x labels Dec 13, 2016

MylesBorins pushed a commit that referenced this pull request Dec 13, 2016

doc: add guide for maintaining V8

4eeac8e

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 21, 2016

doc: add guide for maintaining V8

1ac3014

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

MylesBorins pushed a commit that referenced this pull request Dec 21, 2016

doc: add guide for maintaining V8

facc431

Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

This was referenced Dec 21, 2016

V6.9.3 proposal #10394

Merged

V4.7.1 proposal #10395

Merged

Uh oh!

Conversation

ofrobots commented Nov 24, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ofrobots commented Nov 28, 2016

Uh oh!

ofrobots commented Nov 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants