doc: fix <code> inside stability boxes#9723
Closed
silverwind wants to merge 2 commits intonodejs:masterfrom
Closed
doc: fix <code> inside stability boxes#9723silverwind wants to merge 2 commits intonodejs:masterfrom
silverwind wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
Author
|
Decided to change the background color to be more apparent and restored the padding on the code block because it went missing in a recent commit that styled
|
silverwind
force-pushed
the
doc-code-bg
branch
from
48156f2 to
7c11d00
Compare
silverwind
force-pushed
the
doc-code-bg
branch
from
7c11d00 to
edc9a38
Compare
silverwind
changed the title
lpinca
approved these changes
Nov 22, 2016
Contributor
Author
|
Thanks! Landed in 245a928. |
Contributor
|
I don't think this needs to be backported to 4.x or 6.x, unless the style changes that created the issue are also backported. |
Contributor
Author
|
Right, the issue is not present in |
Contributor
|
@silverwind thanks for figuring out LTS related stuff! In future if you could include the dont-land tags that would help a ton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools, doc
Description of change
Mades
<code>backgrounds semi-transparent so they work on all backgrounds. The inline blocks are rendered as#f2f2f2before and after this change.Before
After
Fixes: #9714