test,benchmark: fix lint errors on v6.x#9029
Closed
Fishrock123 wants to merge 0 commit intonodejs:v6.x-stagingfrom
Closed
test,benchmark: fix lint errors on v6.x#9029Fishrock123 wants to merge 0 commit intonodejs:v6.x-stagingfrom
Fishrock123 wants to merge 0 commit intonodejs:v6.x-stagingfrom
Conversation
nodejs-github-bot
added
benchmark
Contributor
|
LGTM |
MylesBorins
approved these changes
Oct 11, 2016
Contributor
|
Those BSD are kind of concerning, but likely not to do with this |
Fishrock123
added a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #9029 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fishrock123
force-pushed
the
fix-v6.x-staging-lint
branch
from
c7dd0f0 to
5a7dd18
Compare
Contributor
Author
|
Landed in 5a7dd18 thanks |
Member
|
Guess I'm late to this one but LGTM after the fact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test,benchmark
Description of change
cc @Trott / @thealphanerd could you sign off?
CI: https://ci.nodejs.org/job/node-test-pull-request/4457/
Edit: I chose this route because finding the commits is indirect and painful and requires large rebases and stuff