Closed
Conversation
nodejs-github-bot
added
the
c++
Member
|
cc/ @fhinkel |
addaleax
approved these changes
Oct 11, 2016
Member
|
Thanks! LGTM. |
Contributor
Author
|
Hello @fhinkel it's done 😸 |
Member
|
@maasencioh can you please use Thanks. |
rval never existed, it was added as that in 077f9d7 Fixes: nodejs#9001
Contributor
Author
|
@lpinca thanks, I just did it |
targos
approved these changes
Oct 11, 2016
cjihrig
approved these changes
Oct 11, 2016
thefourtheye
approved these changes
Oct 11, 2016
jasnell
approved these changes
Oct 11, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM. This is trivial enough not to wait the full 48 hours
jasnell
pushed a commit
that referenced
this pull request
Oct 11, 2016
rval never existed, it was added as that in 077f9d7 Fixes: #9001 PR-URL: #9023 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Member
|
Landed in 88323e8 |
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2016
rval never existed, it was added as that in 077f9d7 Fixes: #9001 PR-URL: #9023 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
rval never existed, it was added as that in 077f9d7 Fixes: #9001 PR-URL: #9023 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
rval never existed, it was added as that in 077f9d7 Fixes: #9001 PR-URL: #9023 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
rvalnever existed, it was added as that in 077f9d7closes #9001