doc: fix typo in email address in README#8941
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Member
|
LGTM. I'd say this is trivial enough not to wait the full 48 hours. |
Member
|
LGTM if @JacksonTian agrees, I feel we should probably have his sign-off too right? |
Member
|
Introduced in #6388. |
Member
Author
|
@JacksonTian Can you take a quick look at this change? |
Contributor
|
LGTM |
Contributor
JacksonTian
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8941 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8941 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2016
PR-URL: #8941 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #8941 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
@JacksonTian please review. Thanks!