test: cleanup/update test-dgram-error-message-address.js#8938
test: cleanup/update test-dgram-error-message-address.js#8938Goyapa wants to merge 1 commit intonodejs:masterfrom Goyapa:test-dgram-error-message
Conversation
Goyapa
changed the title
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but there is some other cleanup that you could do while you're here. Like getting rid of assert.equal() and assert.notEqual().
These changes would make this change more compelling:
|
|
Fixes: #8925 |
|
@Goyapa while you are at it can you please replace Also you can use the |
|
@ipinca |
|
@Goyapa we can use https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ if it is not a problem for you. |
|
You can also try to edit files on your branch using Github’s web interface, it’s a bit tricky but it’s nice when you don’t want to or can’t use a local git client. |
|
@lpinca |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
|
@lpinca |
* Changes: * var -> const * assert.equal() -> assert.strictEqual() * assert.notEqual() -> assert.notStrictEqual() * Fixes: #8925
|
Landed in 6a73d61 |
* var -> const * assert.equal() -> assert.strictEqual() * assert.notEqual() -> assert.notStrictEqual() Fixes: #8925 PR-URL: #8938 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
* var -> const * assert.equal() -> assert.strictEqual() * assert.notEqual() -> assert.notStrictEqual() Fixes: #8925 PR-URL: #8938 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
* var -> const * assert.equal() -> assert.strictEqual() * assert.notEqual() -> assert.notStrictEqual() Fixes: #8925 PR-URL: #8938 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
* var -> const * assert.equal() -> assert.strictEqual() * assert.notEqual() -> assert.notStrictEqual() Fixes: #8925 PR-URL: #8938 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
11 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
dgram
Description of change
test: cleanup/update test-dgram-error-message-address.js