inspector: no URLs when the debugger is connected by eugeneo · Pull Request #8919 · nodejs/node

eugeneo · 2016-10-04T01:04:17Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

inspector

Description of change

By convention, inspector protocol targets do not advertise connection
URLs when the frontend is already connected as multiple inspector
protocol connections are not supported.

jbergstroem · 2016-10-04T18:40:31Z

(linter fail is my bad -- reimaging one of the vm's)

eugeneo · 2016-10-04T20:09:03Z

Windows failures do not seem to be caused by this change.

eugeneo · 2016-10-14T00:47:30Z

CI: https://ci.nodejs.org/job/node-test-commit/5605/ - seems to be as green as possible

alexkozy · 2016-10-17T16:22:58Z

src/inspector_agent.cc

response.c_str() ?

I used data() - there's is no need for null-terminated string.

bnoordhuis · 2016-10-18T10:14:27Z

src/inspector_agent.cc

A homegrown JSON serializer seems like a recipe for disaster. Is there a way to use V8's JSON.stringify?

If nothing else, FormatJSON() is something of a misnomer because you need to escape the values manually.

v8::JSON::stringify requires V8 context. This code runs on a dedicated (non-V8) thread, can be ran early in the startup (e.g. if the node is started with --debug-brk), needs to run when V8 is suspended on a breakpoint, etc.

I renamed to MapToString. I hope we will not need a "full" JSON serializer :)

bnoordhuis · 2016-10-18T10:16:59Z

src/inspector_agent.cc

This is the tiniest of nits but we use string.size()everywhere else. Can you use it here too?

Thanks. Done.

bnoordhuis · 2016-10-18T10:17:49Z

src/inspector_agent.cc

For my education: is this header necessary and if so, what does it signify?

This is for protocol clients, that are trying to figure out protocol version from this field. It is a wrong check, but apparently some clients did it at the time when the integration was initially implemented.

If it's already obsolete baggage, why add it? I assume those clients you mention will need to be updated anyway.

I agree. Removed the fields. VSCode and Chrome devtools seem unaffected, I do not know what was the tool that used to fail.

eugeneo · 2016-10-18T17:27:50Z

@bnoordhuis Thank you for the review. I uploaded a new version of the patch.

eugeneo · 2016-10-19T23:11:31Z

Fully green CI: https://ci.nodejs.org/job/node-test-pull-request/4583/ :)

ofrobots · 2016-10-20T13:41:48Z

@bnoordhuis PTAL when you get a chance.

bnoordhuis · 2016-10-20T13:44:16Z

I commented a few hours ago. Did anything change?

eugeneo

@bnoordhuis Thank you for the review. I removed those 2 fields and did some manual testing.

New CI: https://ci.nodejs.org/job/node-test-pull-request/4597/

eugeneo · 2016-10-20T17:26:26Z

src/inspector_agent.cc

I agree. Removed the fields. VSCode and Chrome devtools seem unaffected, I do not know what was the tool that used to fail.

By convention, inspector protocol targets do not advertise connection URLs when the frontend is already connected as multiple inspector protocol connections are not supported. PR-URL: #8919 Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

eugeneo · 2016-10-20T20:22:00Z

Landed as da184f4

Fix the following compile-time warning: ../src/inspector_agent.cc:175:19: warning: 'const string node::inspector::{anonymous}::to_string(uint64_t)' defined but not used [-Wunused-function] const std::string to_string(uint64_t number) { Refs: nodejs#8919

By convention, inspector protocol targets do not advertise connection URLs when the frontend is already connected as multiple inspector protocol connections are not supported. PR-URL: #8919 Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2016-11-15T18:43:08Z

@eugeneo I attempted to backport this to v6.x but it broke the test suite

=== release test-inspector ===
Path: inspector/test-inspector
[err] Debugger listening on port 9229.
[err] Warning: This is an experimental feature and could change at any time.
[err] To start debugging, open the following URL in Chrome:
[err]     chrome-devtools://devtools/remote/serve_file/@60cd6e859b9f557d2312f5bf532f6aec5f284980/inspector.html?experiments=true&v8only=true&ws=localhost:9229/e10ba451-8f65-4866-87ce-ed2d8b7e28fd
[err]
AssertionError: false == true
    at TestSession.session.testHttpResponse (/Users/thealphanerd/code/node/v6.x/test/inspector/test-inspector.js:158:12)
    at checkHttpResponse (/Users/thealphanerd/code/node/v6.x/test/inspector/inspector-helper.js:288:15)
    at IncomingMessage.res.on.on (/Users/thealphanerd/code/node/v6.x/test/inspector/inspector-helper.js:89:24)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
Command: out/Release/node /Users/thealphanerd/code/node/v6.x/test/inspector/test-inspector.js

thoughts?

eugeneo · 2016-11-18T00:26:56Z

@thealphanerd I tried cherrypicking this change on top of v6.x-staging - tests seem to pass - https://github.com/eugeneo/node/tree/v6.x-staging

eugeneo · 2016-11-18T00:30:43Z

@thealphanerd - I've also started CI here to see if this is something platform specific.

eugeneo · 2016-11-18T16:36:39Z

@thealphanerd - I see no relevant CI failures - https://ci.nodejs.org/job/node-test-commit/6044/

By convention, inspector protocol targets do not advertise connection URLs when the frontend is already connected as multiple inspector protocol connections are not supported. PR-URL: #8919 Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2016-11-18T18:19:56Z

@eugeneo I've landed it now... must have been something else that landed in the mean time that fixed it
¯_(ツ)_/¯

By convention, inspector protocol targets do not advertise connection URLs when the frontend is already connected as multiple inspector protocol connections are not supported. PR-URL: #8919 Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Oct 4, 2016

MylesBorins force-pushed the master branch from 95ba482 to 2e568d9 Compare October 4, 2016 16:19

alexkozy approved these changes Oct 17, 2016

View reviewed changes

bnoordhuis requested changes Oct 18, 2016

View reviewed changes

rvagg force-pushed the master branch 3 times, most recently from 6f558a7 to 0e6750d Compare October 18, 2016 17:23

eugeneo commented Oct 20, 2016

View reviewed changes

bnoordhuis approved these changes Oct 20, 2016

View reviewed changes

eugeneo closed this Oct 20, 2016

bnoordhuis mentioned this pull request Oct 23, 2016

src: remove unused function #9243

Closed

2 tasks

MylesBorins added dont-land-on-v4.x labels Nov 15, 2016

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Nov 18, 2016

MylesBorins mentioned this pull request Nov 22, 2016

v6.9.2 proposal #9735

Merged

Uh oh!

Conversation

eugeneo commented Oct 4, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

jbergstroem commented Oct 4, 2016

Uh oh!

eugeneo commented Oct 4, 2016

Uh oh!

eugeneo commented Oct 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eugeneo commented Oct 18, 2016

Uh oh!

eugeneo commented Oct 19, 2016

Uh oh!

ofrobots commented Oct 20, 2016

Uh oh!

bnoordhuis commented Oct 20, 2016

Uh oh!

eugeneo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eugeneo commented Oct 20, 2016

Uh oh!

MylesBorins commented Nov 15, 2016

Uh oh!

eugeneo commented Nov 18, 2016

Uh oh!

eugeneo commented Nov 18, 2016

Uh oh!

eugeneo commented Nov 18, 2016

Uh oh!

MylesBorins commented Nov 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants