test: remove &socket from test_inspector_socket#8717
Closed
indutny wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove &socket from test_inspector_socket#8717indutny wants to merge 1 commit intonodejs:masterfrom
&socket from test_inspector_socket#8717indutny wants to merge 1 commit intonodejs:masterfrom
Conversation
What is `socket`, where did it came from? We don't know. On a more serious note: `socket` is function from `sys/socket.h`. There is no way casting it to structure could yield any useful results.
Member
Author
|
Please let me know if I missed something obvious here... |
Member
Author
addaleax
approved these changes
Sep 22, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM. I don’t think you’re missing anything, the address of socket(3) does end up in the cctest executable here.
Member
Author
|
Thanks! |
Contributor
|
/cc @nodejs/v8-inspector |
Contributor
|
This is a pending CL that also fixes this: #8505 (There used to be a variable socket that got removed at some point in the refactorings - that's when the function pointer came into the play) |
Member
Author
|
Oh, cool! Closing this in a favor of #8505 then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
What is
socket, where did it came from? We don't know.On a more serious note:
socketis function fromsys/socket.h. Thereis no way casting it to structure could yield any useful results.
R= @nodejs/v8