timers: length == 0 is untouchable because type checking#8487
Closed
yorkie wants to merge 1 commit intonodejs:masterfrom
Closed
timers: length == 0 is untouchable because type checking#8487yorkie wants to merge 1 commit intonodejs:masterfrom
yorkie wants to merge 1 commit intonodejs:masterfrom
Conversation
yorkie
added
the
timers
Member
|
LGTM if CI is green |
Contributor
|
LGTM |
Contributor
Author
Member
|
Commit subject line is a bit too long, can I suggest "timers: remove unreachable code"? |
yorkie
force-pushed
the
timers/fix-untouchable
branch
from
c5ad7fc to
42fbed1
Compare
Contributor
Author
|
Thank you @lpinca changed to your suggestion :) |
Member
|
LGTM, CI failures look unrelated (one test-crypto-timing-safe-equal failure) |
Contributor
|
LGTM |
Contributor
|
Actually, isn't |
Contributor
Author
|
@Fishrock123 |
Contributor
|
Ah yes. Misunderstood. |
Contributor
Author
|
Landed at 9b0246b :) |
yorkie
added a commit
that referenced
this pull request
Sep 15, 2016
PR-URL: #8487 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8487 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
timers
Description of change
In
setTimetout,setIntervalandsetImmediatefunctions, the case 0 onarguments.lengthare untouchable because anTypeErrorwould be threw and not able to run at that line.