Conversation
The comment about calling the f function seems to have drifted a little. Moving it to be closer to the actual call.
nodejs-github-bot
added
the
c++
|
LGTM |
|
LGTM |
|
The Raspberry Pi failure is unrelated, of course, and due to some ongoing difficulties that have hopefully been resolved now, but in any event, don't need to hold this up IMO. |
|
Landed in a01e8bc |
The comment about calling the f function seems to have drifted a little. Moving it to be closer to the actual call. PR-URL: #8405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Why was this landed without addressing the comments? I'm 99% certain I posted those here, and not in the landed commit..?? |
|
I honestly did not notice the comments until after I had committed the tisdag 6 september 2016 skrev Jeremiah Senkpiel notifications@github.com:
|
The comment about calling the f function seems to have drifted a little. Moving it to be closer to the actual call. PR-URL: nodejs#8405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The comment about calling the f function seems to have drifted a little. Moving it to be closer to the actual call. PR-URL: #8405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
7 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.