Closed
Conversation
Member
|
Looks good to me! |
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
| * **timers**: this phase executes callbacks scheduled by `setTimeout()` | ||
| and `setInterval()`. | ||
| * **I/O callbacks**: most types of callback except timers, `setImmedate()`, close | ||
| * **I/O callbacks**: most types of callback except timers, `setImmediate()`, close |
Contributor
There was a problem hiding this comment.
Does this sentence look complete? I am not able to understand this.
Member
There was a problem hiding this comment.
I didn't read the context but as is I also can't understand it.
Member
There was a problem hiding this comment.
I think this is supposed to read as: all callbacks, but not the ones listed above under timers, the setImmediate() ones, and those listed under close callbacks which are run later…? But ack, it isn’t very clear…
Member
There was a problem hiding this comment.
I agree, reading the full list one can infer something like this:
"executes almost all callbacks with the exception of close callbacks, the ones scheduled by timers and setImmediate()"
It is a long sentence but I think it's better to be explicit.
Contributor
|
Changes look fine, LGTM. |
Member
|
LGTM |
addaleax
pushed a commit
that referenced
this pull request
Sep 2, 2016
PR-URL: #8370 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Member
|
@addaleax yes, will do. |
2 tasks
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Sep 6, 2016
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
PR-URL: nodejs#8370 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
PR-URL: #8370 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 9, 2016
Refs: #8370 (diff) PR-URL: #8400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Refs: #8370 (diff) PR-URL: #8400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fix typos / spelling errors in doc/api and doc/topics