doc: add return type of clientRequest.setTimeout#8356
Closed
MikeRalphson wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add return type of clientRequest.setTimeout#8356MikeRalphson wants to merge 1 commit intonodejs:masterfrom
MikeRalphson wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
http
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
@MikeRalphson can you please update the commit message? |
MikeRalphson
changed the title
MikeRalphson
force-pushed
the
MikeRalphson-patch-1
branch
from
e17f070 to
0536217
Compare
Contributor
Author
|
@lpinca sorry, hopefully that's better (I assumed all lowercase didn't include refs to actual functions etc, from a browse of recent commits). First line of commit msg is now 48 chars. |
Member
|
@MikeRalphson instead of "PR #1699 did not update documentation" I would use the "Refs:" metadata, that is |
MikeRalphson
force-pushed
the
MikeRalphson-patch-1
branch
from
0536217 to
ccb0b3d
Compare
Contributor
Author
|
@lpinca commit message updated to use Refs: as above. |
Contributor
|
LGTM |
Contributor
|
lgtm |
lpinca
pushed a commit
to lpinca/node
that referenced
this pull request
Sep 3, 2016
Refs: nodejs#1699 PR-URL: nodejs#8356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Member
|
Landed in 7e8d994 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Refs: nodejs#1699 PR-URL: nodejs#8356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Document the return type of clientRequest.setTimeout
#1699 did not update documentation