Conversation
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
|
Looks good to me! Could you amend the commit message so that it starts with |
|
@Alexis374 Looks like you only changed the PR title, not the actual commit. To amend the commit message, you'll need a local clone of your github fork on node. Then:
|
|
LGTM with the commit log fix. |
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
|
@addaleax @Fishrock123 I did as you told, please check whether I did sth wrong. |
|
@Alexis374 it looks like there’s a (nobody is claiming that git is easy to work with… :/) |
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: #8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: nodejs#8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md PR-URL: #8315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md