test: additional refactoring/cleanup of buffer tests#8283
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
test: additional refactoring/cleanup of buffer tests#8283jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
* Favor use of strictEqual where possible * Use const as appropriate * Other miscellaneous cleanups
jasnell
added
buffer
Member
Author
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Aug 29, 2016
* Favor use of strictEqual where possible * Use const as appropriate * Other miscellaneous cleanups PR-URL: #8283 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Member
Author
|
Landed in 4537cf2 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
* Favor use of strictEqual where possible * Use const as appropriate * Other miscellaneous cleanups PR-URL: nodejs#8283 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
* Favor use of strictEqual where possible * Use const as appropriate * Other miscellaneous cleanups PR-URL: #8283 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Contributor
|
not landing cleanly, feel free to backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test (buffer)
Description of change
Another round of cleanups for Buffer tests