url: keep auth in url.resolve() if host matches#8215
Closed
imyller wants to merge 1 commit intonodejs:masterfrom
Closed
url: keep auth in url.resolve() if host matches#8215imyller wants to merge 1 commit intonodejs:masterfrom
url.resolve() if host matches#8215imyller wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
url
Member
Member
|
LGTM if CI is green |
Member
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/3805/ |
Member
|
CI failures are unrelated. Landing... |
Member
|
ugh.. nevermind... @imyller... can you rebase this really quick? |
Fixes: nodejs#8165 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller
force-pushed
the
url-resolve-auth
branch
from
5cbab64 to
aaae94e
Compare
Member
Author
|
@jasnell rebased |
Member
|
New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/3822/ |
Member
|
Landed in 51f96df. Thank you! |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Fixes: nodejs#8165 PR-URL: nodejs#8215 Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
adding a don't land tag as this appears to be related to a semver major change not found on v4.x Please feel free to change the label if I am mistaken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
url
Description of change
Keep
authin URL ifhostandhostnameis not changed.Fixes regression introduced in PR #1480
Fixes: #8165