Closed
Conversation
Member
|
LGTM if CI is green. |
Member
|
Looks good to me! |
Contributor
|
LGTM o/ @jun-oka |
Contributor
|
LGTM |
Member
|
CI is green, not sure why the widget hasn't updated? |
Member
|
@Trott might be because we had a race condition, I started https://ci.nodejs.org/job/node-test-pull-request/3757/ but aborted that one when I read that you already had commented here with https://ci.nodejs.org/job/node-test-pull-request/3758/ :) |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
Author
|
Thank you for the comments All ! :) (^O^)／@thealphanerd |
Member
|
LGTM |
fhinkel
pushed a commit
to fhinkel/node
that referenced
this pull request
Aug 21, 2016
PR-URL: nodejs#8191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Member
|
Thanks! Landed in ce8753a. |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
PR-URL: #8191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test vm
Description of change