test: remove internal headers from addons#7947
Closed
gibfahn wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Contributor
a7eaf5d to
4ef5c85
Compare
Member
Author
|
@mscdex Whoops, looks like I removed one line too many. If you could rerun the CI that'd be great. |
Contributor
Contributor
|
The last CI run was green everywhere but FreeBSD. Trying again: https://ci.nodejs.org/job/node-test-pull-request/3505/ LGTM if it comes back green. I guess |
Member
Author
|
FreeBSD failure was this (probaby unrelated): |
Member
Author
|
3rd CI came back green, thanks @cjihrig |
Member
Author
|
@bnoordhuis I'd appreciate a review from you as I'm changing your code. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 5, 2016
PR-URL: #7947 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 9a0d26f! Thank you! |
Member
|
Whoops, forgot to close when landing... |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
PR-URL: #7947 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Contributor
|
neither of these files live in v4.x, adding dont land |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test-addons(UNIX), orvcbuild test-addons nosign(Windows) passesAffected core subsystem(s)
test, addons
Description of change
Continuation of 3c85f4e (in #6734). Make the addons more like userland ones.
@bnoordhuis not sure whether
util.handutil-inl.hwere being used in openssl-binding/binding.cc. The asserts in test.js still seem to pass.EDIT: CI is green