build: fix dependency on missing header file #7945
Merged
bnoordhuis merged 2 commits intonodejs:masterfrom Aug 3, 2016
Merged
Conversation
nodejs-github-bot
added
the
cares
Contributor
|
CI is green. LGTM |
Contributor
|
LGTM |
Depend on src/inspector_agent.h, src/inspector-agent.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: nodejs#7945 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Depend on include/ares_rules.h, src/ares_rules.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: nodejs#7945 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
bnoordhuis
force-pushed
the
fixup-build-deps
branch
from
6f686df to
05c15a0
Compare
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
Depend on src/inspector_agent.h, src/inspector-agent.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: #7945 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
Depend on include/ares_rules.h, src/ares_rules.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: #7945 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
Contributor
|
@bnoordhuis this is not landing cleanly. Would you be willing to backport (if you deem it a good fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apropos the change to deps/cares/cares.gyp, we are the maintainers of that file, it doesn't exist upstream. It's an exception to the rule that changes to files under deps/ should go upstream first.
CI: https://ci.nodejs.org/job/node-test-pull-request/3497/