doc: remove extra space in console.log examples#7885
doc: remove extra space in console.log examples#7885joeyespo wants to merge 5 commits intonodejs:masterfrom
Conversation
|
LGTM |
|
Could you fix the exact same issue in other doc files, please? |
a250325 to
6a28917
Compare
|
@ChALkeR Done! I amended the commit so there's still only one. |
|
LGTM |
|
@joeyespo Cool, thanks! That was an example, though. Full list: Ah, and LGTM either way. |
93df4ac to
7cdfa2e
Compare
|
@ChALkeR Ah, sorry, I misunderstood. Done! I amended the original commit with those. Rebased too. I also found a few more whitespace tweaks while making sure I got everything, along with the inverse of this fix ( I can squash them into one commit or split them out to a new PR if that's preferred. Let me know! |
doc/api/modules.md
Outdated
There was a problem hiding this comment.
There is another whitespace at the end
There was a problem hiding this comment.
Sorry there is nothing. It's the rendering on my phone that is wrong.
|
All changes LGTM. |
doc/api/process.md
Outdated
There was a problem hiding this comment.
Could we also fix the indention to 2 spaces?
03c9347 to
1fb2055
Compare
|
Ok. All comments are addressed. |
1fb2055 to
35f18ee
Compare
|
LGTM |
PR-URL: #7885 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in a single squashed commit... 6ea8c66 |
PR-URL: #7885 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #7885 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #7885 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #7885 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
doc
Description of change
This fixes the
console.logexample in the docs. Before this change, an extra space would be printed, which wouldn't match the example output. Now it's consistent.