Skip to content

tools,test: show signal code when test crashes#7859

Merged
santigimeno merged 1 commit intonodejs:masterfrom
santigimeno:crashed
Jul 31, 2016
Merged

tools,test: show signal code when test crashes#7859
santigimeno merged 1 commit intonodejs:masterfrom
santigimeno:crashed

Conversation

@santigimeno
Copy link
Member

@santigimeno santigimeno commented Jul 24, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, test

Description of change

@santigimeno santigimeno added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 24, 2016
mscdex
mscdex reviewed Jul 24, 2016
View reviewed changes
tools/test.py Outdated
Copy link
Contributor

@mscdex mscdex Jul 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it might be helpful to add a prefix before the number here and below, like "Exit code ".

Copy link
Member Author

@santigimeno santigimeno Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would --- CRASHED (Signal: %d) --- work for you?

Copy link
Contributor

@mscdex mscdex Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, yes.

@santigimeno
Copy link
Member Author

santigimeno commented Jul 26, 2016

PR updated. Thanks!

@bnoordhuis
Copy link
Member

bnoordhuis commented Jul 27, 2016

LGTM but does it print the right thing on Windows?

@santigimeno
Copy link
Member Author

santigimeno commented Jul 27, 2016

does it print the right thing on Windows?

@bnoordhuis I don't know. Is there a simple way to force a crash on Windows?

@santigimeno
Copy link
Member Author

santigimeno commented Jul 27, 2016

PR update adding CRASHED info to the tap output

@gibfahn
Copy link
Member

gibfahn commented Jul 29, 2016

@santigimeno I normally use --expect-fail (in test.py#L1325) to get tests to fail.

@santigimeno
Copy link
Member Author

santigimeno commented Jul 30, 2016

@gibfahn I didn't know about --expect-fail and it looks very useful but I don't think it's what I'm looking for. I want to create a test that crashes on Windows (HasCrashed(self) returns true) to check whether this change makes any sense on Windows at all. Thanks!

@santigimeno
Copy link
Member Author

santigimeno commented Jul 30, 2016

PR updated printing the Signal Code on every platform but Windows.

bnoordhuis
bnoordhuis reviewed Jul 30, 2016
View reviewed changes
tools/test.py Outdated
Copy link
Member

@bnoordhuis bnoordhuis Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd negate in PrintCrashed() itself.

@bnoordhuis
Copy link
Member

bnoordhuis commented Jul 30, 2016

LGTM with a suggestion and a style nit.

@santigimeno santigimeno mentioned this pull request Jul 31, 2016
Closed
2 tasks
@santigimeno
Copy link
Member Author

santigimeno commented Jul 31, 2016

PR updated with @bnoordhuis comments. Thanks!

@santigimeno
tools,test: show signal code when test crashes
df4ef63 
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.

PR-URL: nodejs#7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@santigimeno santigimeno merged commit df4ef63 into nodejs:master Jul 31, 2016
@santigimeno
Copy link
Member Author

santigimeno commented Jul 31, 2016

Landed in df4ef63. Thanks!

@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@santigimeno @cjihrig
tools,test: show signal code when test crashes
fecf611 
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.

PR-URL: #7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@santigimeno
tools,test: show signal code when test crashes
a68d958 
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.

PR-URL: #7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@santigimeno @rvagg
tools,test: show signal code when test crashes
9e9228d 
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.

PR-URL: #7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@santigimeno @MylesBorins
tools,test: show signal code when test crashes
76b8d81 
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.

PR-URL: #7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@santigimeno @bnoordhuis @gibfahn @mscdex @MylesBorins