doc: correct sample output of buf.compare#7777
Closed
khalsah wants to merge 1 commit intonodejs:masterfrom
khalsah:doc-fix-buf-compare
Closed
doc: correct sample output of buf.compare#7777khalsah wants to merge 1 commit intonodejs:masterfrom khalsah:doc-fix-buf-compare
khalsah wants to merge 1 commit intonodejs:masterfrom
khalsah:doc-fix-buf-compare
Conversation
comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.
nodejs-github-bot
added
buffer
Member
|
LGTM |
Contributor
|
LGTM. Good catch. |
Contributor
|
Landed in 59741a9. Thanks! |
cjihrig
pushed a commit
that referenced
this pull request
Jul 18, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
Jul 19, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
Jul 20, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: #7777 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
comparing the buffers
ABCandABCDreturns-1not1.