doc: fix added: date for NODE_REPL_HISTORY#7775
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix added: date for NODE_REPL_HISTORY#7775addaleax wants to merge 1 commit intonodejs:masterfrom
added: date for NODE_REPL_HISTORY#7775addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
`NODE_REPL_HISTORY` was introduced in v3.0.0 (see e.g. 6faf17c).
Contributor
Member
|
@Fishrock123 you're thinking of the cli label here? That's intentional as of nodejs/github-bot#47 |
Contributor
|
Looks alright to me. EDIT: referring to the PR labeling |
Contributor
|
LGTM |
Contributor
|
LGTM. BTW, are we okay backticks in commit messages? |
Member
Author
|
I think they are actually encouraged if their content would otherwise be parsed non-trivially by markdown parsers in the changelog (e.g. for words starting/ending with underscores)? |
Contributor
|
They might be nice for changelog rendering, but I'd personally avoid them until GitHub decides to render them in the commit log (like they interestingly already do for |
Member
Author
|
I’d like to keep them, yeah. For me they make it easier to parse, even without markdown rendering. :) |
Member
Author
|
Landed in c67ec57 |
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Aug 5, 2016
`NODE_REPL_HISTORY` was introduced in v3.0.0 (see e.g. 6faf17c). PR-URL: nodejs#7775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NODE_REPL_HISTORYwas introduced in v3.0.0 (see e.g. 6faf17c).I noticed this while doing the conflict resolution for the backport in #7677, and I think I wanted to PR that against master right then, but ended up correcting the version in the backport – sorry for that.