Conversation
Member
Contributor
Author
|
@santigimeno CI was green. |
Member
|
LGTM |
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: nodejs#7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jul 18, 2016
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: #7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jul 20, 2016
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: #7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Contributor
|
@cjihrig this is not landing cleanly on v4.x. Please feel free to manually backport |
Member
|
Caveat emptor: this pull request introduces bugs in at least |
Contributor
Author
|
I'm reviewing all the tests in this PR and will submit a follow up that fixes any such bugs. |
Contributor
Author
|
I see that @bnoordhuis covered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and
let/constin favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup of these tests such as the use ofassert.strictEqual()andcommon.mustCall()is also included.R= @nodejs/testing