Conversation
This change is in preparation for lint-enforced brace style.
This change is in preparation for a lint rule to enforce brace style.
This change is in preparation for lint enforcement of brace style.
Enable `brace-style` in ESLint. Ref: nodejs#7094 (comment)
nodejs-github-bot
added
module
Member
Author
Contributor
|
LGTM |
Member
Author
|
Only failure on CI is a build failure on a Raspberry Pi device. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Fishrock123
removed
module
| return function() { | ||
| return stream[method].apply(stream, arguments); | ||
| }; | ||
| }(i); |
Contributor
There was a problem hiding this comment.
Unrelated to this change, but I think one level of function wrapping can be removed here:
this[i] = function(method) {
return stream[method].apply(stream, arguments);
}(i);
Contributor
|
LGTM |
Member
Author
|
@Fishrock123 Should I treat your "confused" reaction merely as an expression of mild disappointment? Or should I treat it as a "-1, do not do this without successfully persuading me first that this is A Good Thing"? (Either way, would I be correct to guess that your concerns are around churn / whitespace-only changes?) |
Contributor
|
Much thanks for taking care of this. LGTM. |
Member
Author
|
I'll land this after another 12 hours or so unless someone objects. |
Member
|
🎆 lgtm |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2016
This change is in preparation for lint-enforced brace style. PR-URL: nodejs#7630 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2016
Enable `brace-style` in ESLint. Ref: nodejs#7094 (comment) PR-URL: nodejs#7630 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Member
Author
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
This change is in preparation for lint-enforced brace style. PR-URL: #7630 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
Enable `brace-style` in ESLint. Ref: #7094 (comment) PR-URL: #7630 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
4 tasks
Contributor
|
@Trott would you be willing to backport? |
Member
Author
|
@thealphanerd Backported in #8348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools lib benchmark test
Description of change
Enable
brace-stylein ESLint.Ref: #7094 (comment)
/cc @trevnorris @silverwind