doc: fix exec stdout & stderr default type in child_process#7361
doc: fix exec stdout & stderr default type in child_process#7361sartrey wants to merge 3 commits intonodejs:masterfrom sartrey:master
Conversation
doc/api/child_process.md
Outdated
| the output as UTF-8 and pass strings to the callback. The `encoding` option | ||
| can be used to specify the character encoding used to decode the stdout and | ||
| stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to | ||
| stderr output. If `encoding` is `'buffer'` (or not a valid Buffer encoding), `Buffer` objects will be passed to |
There was a problem hiding this comment.
I think this should say something like:
If
encodingis'buffer', or an unrecognized character encoding,Bufferobjects will be passed to
There was a problem hiding this comment.
Also, please wrap lines at 80 characters.
|
@cjihrig I will edit these lines. |
doc/api/child_process.md
Outdated
| can be used to specify the character encoding used to decode the stdout and | ||
| stderr output. If `encoding` is `'buffer'`, `Buffer` objects will be passed to | ||
| the callback instead. | ||
| stderr output. If `encoding` is `'buffer'`, or an unrecognized character encoding, |
There was a problem hiding this comment.
With a quick check, it seems like these lines are still > 80 characters.
|
@cjihrig Sorry for my poor English, here is my true meaning in Chinese 我在文档的前半部分看到一些行也超过了80字符, 如果我必须精确遵循80字符,请告诉我,我会修改的。 |
|
Please wrap them at 80 characters or less. There are some other longer lines, but they shouldn't be that way (no need to change the other ones in this PR though). |
|
@cjihrig Please review this new commit. |
|
LGTM |
|
Thanks! Landed in 926707f. |
Checklist
Affected core subsystem(s)
Description of change
add words in child_process docs about invalid Buffer encoding leading to a default buffer output