doc: Fs access doc clarity v6x#7321
Closed
lance wants to merge 2 commits intonodejs:v6.xfrom
lance:fs-access-doc-clarity-v6x
Closed
doc: Fs access doc clarity v6x#7321lance wants to merge 2 commits intonodejs:v6.xfrom lance:fs-access-doc-clarity-v6x
lance wants to merge 2 commits intonodejs:v6.xfrom
lance:fs-access-doc-clarity-v6x
Conversation
Cherry picked from d976d66
2 tasks
Member
|
The changes to |
These changes should not have been carried over from master.
Member
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
Member
|
Landed in 1e7a7be |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
Port
doc/fs/api.mddocumentation changes to the v6.x branch. This change includes @jasnell's recent documentation changes regardingfs.constants. It is not clear to me if these changes should be included in the PR or not. If not, let me know and I'll update the PR.Cherry picked from d976d66
Ref: #7113