doc: add added: information for stream#7287
doc: add added: information for stream#7287italoacasas wants to merge 12 commits intonodejs:masterfrom italoacasas:docs/add-added-stream
added: information for stream#7287Conversation
|
Some minor things:
Other than that, the actual content of the PR LGTM |
| #### Class: stream.Writable | ||
| <!-- YAML | ||
| added: v0.3.0 | ||
| --> |
|
Writable Streams section is done. |
|
Readable Streams section is done |
| ##### writable.end([chunk][, encoding][, callback]) | ||
| <!-- YAML | ||
| added: v0.9.9 | ||
| --> |
There was a problem hiding this comment.
$ nvm use 0.9.4
Now using node v0.9.4
$ node
> typeof require('stream').Writable.prototype.end
'function'
There was a problem hiding this comment.
Yeah, but in 0.9.4 that method doesn't accept a callback
There was a problem hiding this comment.
@italoacasas I’d still prefer to go with the version it was added in; adding some sort of changelog for individual methods is definitely planned.
|
LGTM with |
|
@italoacasas ping |
|
sorry for the late response. I was on vacation, I'll finish this PR this week. |
|
I'm back working on this. |
|
This should be ready, I don't find any other place where to add |
|
LGTM |
|
Landed in |
Ref: nodejs#6578 PR-URL: nodejs#7287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
|
this is not landing cleanly on v4.x. Please submit a backport if you would like to see it land |
|
I'm going to do it tonight |
6 participants
Checklist
Affected core subsystem(s)
Description of change
Add
added:information forstream