Conversation
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.
| child.stdin.end('.exit'); | ||
| })); | ||
|
|
||
| child.on('exit', common.mustCall(function(c) { |
There was a problem hiding this comment.
should this be 'close'?
There was a problem hiding this comment.
In this particular case, I don't think it matters either way. But I'm happy to change it to close if that is more idiomatic or avoids problems that I'm currently unaware of in the existing code.
|
Only failure was a build failure on a Raspberry Pi. Trying again: https://ci.nodejs.org/job/node-test-pull-request/2923/ |
|
R=@indutny? |
|
LGTM if it works |
|
@Trott I'd suggest running stress tests for it, just to be sure that it won't be flaky in the future. |
Not sure the last time anyone tried to run a stress test across all targets, but here we go! https://ci.nodejs.org/job/node-stress-single-test/754/ |
|
Stress test results: One build failure, one Jenkins misconfiguration (since fixed, but it resulted in the job getting canceled), and a whole bunch of green across Windows, Raspberry Pi, Linux, OS X, etc. |
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: nodejs#7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
Landed in 101bda1 |
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix issues with disabled test-debug-brk-no-arg and re-enable the test. PR-URL: #7143 Reviewed-By: Fedor Indutny <fedor@indutny.com>
4 participants
Checklist
Affected core subsystem(s)
test debugger
Description of change
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.